Playwright test suite cleaned, 10 janitor violations resolved
Ten violations from the codebase's static analysis tool were addressed, with five dead-code methods removed, an architectural boundary violation fixed, and a duplicate test eliminated.
The Playwright test infrastructure received a thorough cleaning. Five methods that served no purpose—unused locators like and —were stripped out from . An architectural boundary violation was also resolved: was moved out of the pages directory to prevent pages from importing other pages, a pattern that static analysis flagged as problematic.
A duplicate test case ("should add disconnected node if nothing is selected") that existed in two locations was consolidated, keeping the canonical version in the canvas actions spec. The janitor baseline was updated to reflect 515 violations instead of 525—a 10-violation reduction that represents cleaner, more maintainable test code.
In the testing package, test infrastructure becomes the foundation other tests rely on. Clutter there creates drag everywhere.
View Original GitHub Description
Summary
- Remove 5 dead-code methods (
getQuickConnectEmptyState,getCredentialSelectInput,getNodeGroupTitle,getNodeGroupSectionHeader,getNodeGroupCard) - Fix boundary-protection violation by moving
BuilderSetupWizardPage→pages/components/BuilderSetupWizard(pages should not import other pages) - Remove duplicate test "should add disconnected node if nothing is selected" from
actions.spec.ts(canonical version lives inbuilding-blocks/canvas-actions.spec.ts) - Update janitor baseline: 525 → 515 violations
Test plan
-
pnpm typecheckpasses clean -
pnpm janitorshows 0 new violations against updated baseline - CI passes
🤖 Generated with Claude Code